-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: leveldb key store #35
feat: leveldb key store #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write some test cases for LevelDBStore
:)
fcdd386
to
2bcae79
Compare
이 PR과는 다소 관련이 없지만.. |
server/api/walletapi.go
Outdated
@@ -43,7 +43,7 @@ func (w *WalletApi) GetWallet(context *gin.Context) { | |||
return | |||
} | |||
|
|||
key := w.store.Get(request.ID) | |||
key, err := w.store.Get(request.ID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to handle this error.
keychain/leveldb/store_test.go
Outdated
func TestKeyStore_Get(t *testing.T) { | ||
// set | ||
dbProvider := leveldb.CreateNewDBProvider(TestTbPath) | ||
defer func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can extract this defer anonymous function :)
Please fix the conflict :) |
7bc8499
to
25c89d4
Compare
25c89d4
to
9028148
Compare
No description provided.